-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the compiler version to v0.49 #2061
Conversation
.../typespec-test/test/widget_dpg/generated/typespec-ts/sources/generated/src/api/operations.ts
Show resolved
Hide resolved
packages/typespec-test/package.json
Outdated
"@azure-tools/typespec-autorest": ">=0.34.0 <1.0.0", | ||
"@azure-tools/typespec-client-generator-core": "0.35.0-dev.9", | ||
"@typespec/openapi": ">=0.49.0 <1.0.0", | ||
"@azure-tools/typespec-autorest": ">=0.35.0 <1.0.0", | ||
"@typespec/openapi3": ">=0.48.0 <1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we still using 0.48.0 for openapi3 and prettier-plugin-typespec ? also, do we really rely on prettier-plugin-typespec ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated openapi3 to v0.49 now and remvoed the prettier-plugin-typespec, before I used this to format our tsp codes and I think we could remove this because we could do that by tsp format
command.
{ | ||
outputPath: "internal", | ||
inputPath: "azure/client-generator-core/internal" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@internal is deprecated and these test cases are removed from cadl-ranch.
"@typespec/rest": ">=0.48.0 <1.0.0", | ||
"@typespec/versioning": ">=0.48.0 <1.0.0" | ||
"@azure-tools/typespec-azure-core": ">=0.35.0 <1.0.0", | ||
"@azure-tools/typespec-client-generator-core": ">=0.35.0 <1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are using peerDependency, do we really need to change this version number here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the compatibility issue caused by tcgc which would fail to compile. So we have to upgrade to the latest.
Another point is we have to upgrade to the latest for new features.
No description provided.