use-string-as-offset-datetime-type-in-modular #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
sarangan12,
joheredi and
MaryGao
as code owners
MaryGao
reviewed
Sep 18, 2023
| @@ -1080,7 +1080,7 @@ function emitStdScalar( | |||
| case "plainTime": | |||
| return { type: "datetime", format: newScalar.format ?? "time" }; | |||
| case "offsetDateTime": | |||
| return { type: "datetime", format: newScalar.format ?? "rfc7231" }; | |||
| return { type: "string" }; | |||
There was a problem hiding this comment.
Do you think we should apply this change to RLC also?
I have no strong preference but it seems reasonable to not generate Date for RLC if modular won't use date.
Core would use ISO format by default.
https://github.com/MaryGao/azure-sdk-for-js/blob/update-emitter-package-lock-file/sdk/core/core-client-rest/src/urlHelpers.ts#L50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Azure/azure-sdk-for-js#27087 (comment)