-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the cadl-ranch cases for encode and empty model cases #1875
Conversation
.path(`/encode/duration/header/iso8601-array`) | ||
.get({ | ||
headers: { | ||
duration: ["P40D", "P50D"] as any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiaozha I notice that RawHttpHeadersInput
only allows for string|number|boolean
which means there would exist type inference conflict for this property.
It feels like as any
is just a walkaround and would suggest to update the RawHttpHeadersInput
header to allow some values like string[]
or also build a helper function for the default csv format.
How do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we should change the RawHttpHeadersInput to add string[] type. let's add a helper for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I'll apply that change.
Integrate the cadl-ranch cases for:
@encode
with header and query