-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dpg code gen fix docs #1861
Dpg code gen fix docs #1861
Conversation
* Upgrade the cadl-ranch version * Add test cases for encode * Typo fix * Change to workspace
may fix this #1841 |
new Set(operation.responses.flatMap((r) => r.statusCodes)).values() | ||
); | ||
|
||
statusCodes.push("Default"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider LogicalResponse here ? @MaryGao
export class EventGridClient { | ||
private _client: EventGridContext; | ||
|
||
/** Azure Messaging EventGrid Client */ | ||
constructor( | ||
endpoint: string, | ||
credential: KeyCredential, | ||
options: ClientOptions = {} | ||
options: EventGridClientOptions = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder, may need to check the ClientOptions in the rest level. Also, should we generate EventGridClientOptions if there's no actual difference between EventGridClientOptions and ClientOptions ? For RLC, the answer is no, right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the logic to remove if no client level parameters in a separate PR
…ure#1869) * try fix subscriptionId in tenant level * use overload to fix subscription optional * refine and fix smoke test * fix test and resolve comments * fix sample transform
The classical client was missing method names. Adding them, also a couple of other fixes: