Support @overload & @sharedRoute #1848
Conversation
| id: string; | ||
| } | ||
| @route("/overload") | ||
| interface OveralodOperations { |
There was a problem hiding this comment.
@joheredi Could you help review the overload cases and their generated code?
| @@ -74,11 +75,15 @@ export function isDefinedStatusCode(statusCode: StatusCode) { | |||
| return statusCode !== "*"; | |||
| } | |||
|
|
|||
| export function isBinaryPayload(body: Type, contentType: string) { | |||
| export function isBinaryPayload( | |||
There was a problem hiding this comment.
Now that TypeSpec supports @encode I wonder if we can leverage it to get rid of this complex logic.
There was a problem hiding this comment.
https://github.com/Azure/autorest.typescript/blob/4d5f63021d4cad58d958eec6f674151d1f23d7b7/packages/typespec-ts/src/modelUtils.ts#L850-L860Currently we already have this implemented.
This check helps on binary body not byte in a normal model.
| @overload(OveralodOperations.getThing) | ||
| getString(@body param: string): string; | ||
|
|
||
| @overload(OveralodOperations.getThing) |
There was a problem hiding this comment.
@m-nash, did we get to an agreement on how we'll do overloads? Does this align with that?
There was a problem hiding this comment.
I moved the current overload cases to client.tsp. I notice that we have an issue https://github.com/Azure/typespec-azure/issues/2738 in Project TOM but not started yet.
packages/typespec-ts/test/integration/generated/mediaTypes/tspconfig.yaml
Show resolved
Hide resolved
I re-organizated these test cases and their path can't be shared. |
fixes #1760 #1763
Leverage the TypeScript overload to support the decorators @SharedRoute and @overload.
Adding below test cases: