Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try-fix-doc-in-params-tag #1846

Merged
merged 2 commits into from
May 17, 2023
Merged

try-fix-doc-in-params-tag #1846

merged 2 commits into from
May 17, 2023

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented May 16, 2023

fixes #1821

@qiaozha qiaozha marked this pull request as ready for review May 16, 2023 02:10
MaryGao
MaryGao reviewed May 16, 2023
View reviewed changes
...torest.typescript/test/rlcIntegration/generated/bodyComplexRest/src/bodyComplexRestClient.ts
@@ -7,7 +7,7 @@ import { BodyComplexRestClient } from "./clientDefinitions";

/**
* Initialize a new instance of `BodyComplexRestClient`
* @param options type: ClientOptions, the parameter for all optional parameters
* @param options - the parameter for all optional parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiaozha @joheredi Do you think we could add the @typescript-eslint/naming-convention validation in our build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least not for rest level client, they will easily break this rule .

qiaozha
qiaozha commented May 17, 2023
View reviewed changes
packages/autorest.typescript/test/commands/smoke-test-list.ts
// branch: "925e8285703ddd461588d8f5fbf14bd97c286fab",
// buildTag: "ci_3"
// },
...getArmReadmes(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this merged, those test case are comment out by accident.

@MaryGao MaryGao merged commit d4f78fb into Azure:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues #4: CADL Generated Code Issue in EventGrid SDK
2 participants
@qiaozha @MaryGao