-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiclient in modular support #1830
Conversation
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/api/bar/BarContext.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/rest/bar/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/rest/foo/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/api/foo/operations.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/api/foo/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/authoring/generated/typespec-ts/src/clientDefinitions.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/review/eventgrid.api.md
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/operations.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/api/bar/operations.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/multiclient_modular/generated/typespec-ts/src/api/bar/BarContext.ts
Outdated
Show resolved
Hide resolved
...ages/typespec-test/test/multiclient_modular/generated/typespec-ts/package-files/package.json
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/index.ts
Outdated
Show resolved
Hide resolved
...ages/typespec-test/test/loadtesting_modular/generated/typespec-ts/package-files/package.json
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
.../test/loadtesting_modular/generated/typespec-ts/src/loadTestAdministration/api/operations.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have a few places to improve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, hope this can accelerate the review.
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/models/models.ts
Show resolved
Hide resolved
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/operations.ts
Show resolved
Hide resolved
packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/models/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/api/index.ts
Outdated
Show resolved
Hide resolved
.../test/loadtesting_modular/generated/typespec-ts/src/loadTestAdministration/api/operations.ts
Show resolved
Hide resolved
packages/typespec-test/test/openai_modular/generated/typespec-ts/src/api/operations.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple thoughts
packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/api/index.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/models/index.ts
Outdated
Show resolved
Hide resolved
@xirzec @mpodwysocki I have removed the top level |
Pending on #1933 to be fixed. |
This PR is mainly focus on how to implement multiple subclients in the Modular library and see the design https://github.com/Azure/azure-sdk-for-js/pull/26164/files
And the following items are non-goals of this PR:
In this
packages/typespec-test/test/loadtesting_modular
smoke test case, we have two subclientsLoadTestRunClient
andLoadTestAdministrationClient
in the Modular layer, and they both point to the same @service, which means the RLC layer is single endpoint.our current code structure is
On the subpath exports, we export the following subpaths
Based on our latest discussion, "We only need one way to import these things without there being ambiguity about which way is correct". I have removed the top level
api/index.ts
andmodels/index.ts
in the multi-client modular case.Remove
./rest
subpath export as discussed in the Q&A session.