Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing document #1627

Merged
merged 15 commits into from
Nov 1, 2022
Merged

Update contributing document #1627

merged 15 commits into from
Nov 1, 2022

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Oct 21, 2022 •
edited by MaryGao
Loading

fixes #1611

MaryGao
MaryGao reviewed Oct 21, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
MaryGao
MaryGao reviewed Oct 21, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lirenhe
lirenhe reviewed Oct 21, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lirenhe
lirenhe reviewed Oct 21, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@qiaozha qiaozha marked this pull request as ready for review October 28, 2022 02:38
@qiaozha
Copy link
Member Author

qiaozha commented Oct 28, 2022

@MaryGao @lirenhe I have update the contributing guide and readme.md mostly according to your comments, Please review again. Thanks

@qiaozha
Copy link
Member Author

qiaozha commented Oct 28, 2022

@joheredi @xirzec Could you also help review this update for both contributing guide and readme.md ?

joheredi
joheredi approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job thanks for cleaning this up

xirzec
xirzec approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you for cleaning this up and providing more launch.json debug targets!

lirenhe
lirenhe approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaryGao
MaryGao approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha qiaozha merged commit 96cf894 into Azure:main Nov 1, 2022
@qiaozha qiaozha deleted the update-contributing-document branch November 1, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@lirenhe lirenhe lirenhe approved these changes

@MaryGao MaryGao MaryGao approved these changes

@joheredi joheredi joheredi approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributing.md is a bit out of date
5 participants
@qiaozha @xirzec @lirenhe @MaryGao @joheredi