Add compat dependency#1324
Merged
sarangan12 merged 2 commits intoAzure:mainfrom Mar 1, 2022
Merged
Conversation
joheredi
reviewed
Feb 22, 2022
| namespaceImport: "coreRestPipeline", | ||
| moduleSpecifier: "@azure/core-rest-pipeline" | ||
| }); | ||
| modelsIndexFile.addImportDeclaration({ |
Member
There was a problem hiding this comment.
Do we need to check for compatMode before importing this?
Contributor
Author
There was a problem hiding this comment.
Actually nope. All unused imports will be removed at the end by the prettier.
joheredi
reviewed
Feb 22, 2022
joheredi
approved these changes
Feb 22, 2022
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
Looks good, I wonder if it would make more sense to have the test as a Smoke Test instead of an integration test because we are not adding any spec.ts files
sarangan12
force-pushed
the
AddCompatDependency
branch
from
4759671 to
30a8169
Compare
3 tasks
sarangan12
force-pushed
the
AddCompatDependency
branch
from
25564d7 to
9f5f95a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add the option flag
core-compat-http-modeto support the SDK generation using the new@azure/core-compat-httppackage.