Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading prettier to version 2.5.1 in packageFileGenerator #1271

Conversation

JonathanCrd
Copy link
Member

Solves #1270

Upgrading prettier dev-dependency from ^2.2.1 to ^2.5.1 for generated packages.

@JonathanCrd JonathanCrd self-assigned this Dec 21, 2021
@JonathanCrd JonathanCrd marked this pull request as draft December 21, 2021 22:27
@JonathanCrd
Copy link
Member Author

/azp run js - autorest.typescript (BuildStage VersionToleranceTests)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JonathanCrd JonathanCrd marked this pull request as ready for review January 4, 2022 00:17
@JonathanCrd
Copy link
Member Author

This PR is ready for review, the only manual change was on "PackageFileGenerator.ts". All the other changes are generated.

@ramya-rao-a
Copy link
Contributor

@JonathanCrd In #1264, we already merged the changes to the copyright... Can you get the changes from main and update this PR so that we have only the prettier related changes in the diff?

@JonathanCrd
Copy link
Member Author

@JonathanCrd In #1264, we already merged the changes to the copyright... Can you get the changes from main and update this PR so that we have only the prettier related changes in the diff?

Sure thing :)

@JonathanCrd JonathanCrd merged commit d91dc87 into Azure:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants