add test for error deserialization #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "name": "@microsoft.azure/autorest.testserver", | ||
| "version": "3.0.3", | ||
| "version": "3.0.4", |
Member
There was a problem hiding this comment.
Probably update that to 3.0.5 when you other PR merge
Contributor
Author
There was a problem hiding this comment.
yeah, i'm going to merge this one first, i'm leaving the other one on the back-burner for a bit, need to make some style changes to my autorest python pr for that, so I'm going to leave this one 3.04. thanks @timotheeguerin
timotheeguerin
approved these changes
Jan 22, 2021
Member
|
I recommend you install the |
Contributor
Author
|
@timotheeguerin you are very right, doing it now thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python has an issue where, in the case of failed error model deserialization, we still want to return an
HttpResponseErrorto users, not a deserialization error. This is a test that throws an incorrect error model, that should result in a deserialization error. Ideally, your autorest code should throw anHttpResponseErrorinstead of aDeserializationError