if constant is optional, don't force to value #952
Conversation
| self.client_default_value = client_default_value | ||
|
|
||
| @property | ||
| def constant(self) -> bool: |
There was a problem hiding this comment.
decided to make constant and validation_map readonly properties to unclutter the main__init__ and because we don't set them later
| :ivar parameter: Default value: "value1". | ||
| :vartype parameter: str | ||
| :param parameter: |
| :ivar parameter: Default value: "value1". | ||
| :vartype parameter: str | ||
| :param parameter: |
There was a problem hiding this comment.
swagger. This is an optional constant with no default, so we default to None.
The doc should also be improved here, so we show the one non-None value. This is included in the same docstring issue
There was a problem hiding this comment.
add docstring fix to this PR
| :type max_product_display_name: str | ||
| :ivar capacity: Capacity of product. For example, 4 people. Default value: "Large". | ||
| :vartype capacity: str | ||
| :param capacity: Capacity of product. For example, 4 people. |
There was a problem hiding this comment.
swagger. Since current behavior of enum is modelAsString defaults to False, and required defaults to False, this param is an optional constant with no default value
There was a problem hiding this comment.
ask tim about whether modelAsString defaults to false or true
| :type max_product_display_name: str | ||
| :ivar capacity: Capacity of product. For example, 4 people. Default value: "Large". | ||
| :vartype capacity: str | ||
| :param capacity: Capacity of product. For example, 4 people. |
There was a problem hiding this comment.
Same param as above
| :vartype const_string: str | ||
| :ivar const_string_as_enum: Constant string as Enum. Default value: "constant_string_as_enum". | ||
| :vartype const_string_as_enum: str | ||
| :param const_string_as_enum: Constant string as Enum. |
There was a problem hiding this comment.
Not required, no default value
| product_id: str, | ||
| description: Optional[str] = None, | ||
| max_product_display_name: Optional[str] = None, | ||
| capacity: Optional[str] = "Large", |
There was a problem hiding this comment.
as you'll notice, the default for optional constants in the method signature is a value. This has to do with this issue. Still need to find a good non-breaking way around this
|
/azp run autorest.python - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into fix_content_type_kwarg * 'autorestv3' of https://github.com/Azure/autorest.python: if constant is optional, don't force to value (#952) add support and tests for anything (#946) combine method signature function (#942) Update operations.md Update operations.md poll by default for data plane (#936) don't split docstrings on hyphens (#931) Update initializing.md
…into prepare_request * 'autorestv3' of https://github.com/Azure/autorest.python: Update ChangeLog.md fix lro parameterization with constant params (#968) Update package.json Update ChangeLog.md fix content type kwarg (#956) if constant is optional, don't force to value (#952) add support and tests for anything (#946)
…ython into hybrid * 'prepare_request' of https://github.com/Azure/autorest.python: improve send_request docstring, allow send_request to be private regen with new show flags regen without PipelineTransportHttpRequest import multiapi generating revert multiapi to version in autorestv3 branch all azure vanilla tests passing temp switch make_request fixture to send_request azure tests passing Update ChangeLog.md fix lro parameterization with constant params (#968) temp vanilla llc passing make azure legacy folder, all but storage generating Update package.json Update ChangeLog.md fix content type kwarg (#956) if constant is optional, don't force to value (#952) add support and tests for anything (#946)
fixes #950, fixes #953