Skip to content

Conversation

@amrElroumy
Copy link

Upgrading @autorest/modelerfour to 4.15.442 to address this issue Azure/autorest#3630

@amrElroumy amrElroumy requested a review from iscai-msft January 15, 2021 08:06
@amrElroumy
Copy link
Author

@iscai-msft we need to upgrade @autorest/modelerfour to 4.15.442 to fix an issue with $ref reporting cycles. I'm not sure how I can trigger the CI build for this PR to ascertain that I'm not introducing any regressions.

Can you help?

@iscai-msft
Copy link
Contributor

iscai-msft commented Jan 15, 2021

@amrElroumy looks loike CI is stuck. This might be because you are committing from your own personal fork. When setting up the CI for this repo, we made it to run when merging a PR from the original repo, so I don't actually knows if it runs when merging a PR from your own fork. I'm actually going to add a changelog update to this, so I'll take care of getting this PR merged and a new version of autorest.python released today.

In the meantime, you can also make your autorest calls with --use=@autorest/[email protected] if you're blocked.

Thank you so much for contributing!

@iscai-msft
Copy link
Contributor

/azp run autorest.python - ci

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@iscai-msft
Copy link
Contributor

@amrElroumy apologies, the CI does seem like it can't handle commiting PRs from forks. I'll follow up on this, but in the meantime, I'm going to create my own PR that duplicates this from the main repo.

Thank you so much for your help!

@iscai-msft iscai-msft closed this Jan 15, 2021
@iscai-msft iscai-msft reopened this Jan 15, 2021
@iscai-msft
Copy link
Contributor

/azp run autorest.python - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft iscai-msft closed this Jan 15, 2021
@Azure Azure deleted a comment from azure-pipelines bot Jan 15, 2021
@iscai-msft
Copy link
Contributor

@amrElroumy you can now commit PRs from forks, many many thanks to @timotheeguerin for his work!

@amrElroumy I already opened another pr with this fix in the meantime and merged it. The new autorest python version is now up on npm with your fix, thank you so much again! Using the flag --python should automatically get you the new autorest.python version (5.6.0). if this is not the case, run autorest --reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants