add enum description son top of declaration, wrap comments #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsntcy
reviewed
Dec 9, 2020
…into comment_bug * 'autorestv3' of https://github.com/Azure/autorest.python: add default value 'api-key' for `--credential-key-header-name` (#840)
iscai-msft
added a commit
that referenced
this pull request
Dec 23, 2020
…into paging_separate_operations * 'autorestv3' of https://github.com/Azure/autorest.python: add enum description son top of declaration, wrap comments (#844) add default value 'api-key' for `--credential-key-header-name` (#840) update head-as-boolean spec
iscai-msft
added a commit
that referenced
this pull request
Jan 4, 2021
…into improve_lro_docstrings * 'autorestv3' of https://github.com/Azure/autorest.python: add enum description son top of declaration, wrap comments (#844) add default value 'api-key' for `--credential-key-header-name` (#840) update head-as-boolean spec
iscai-msft
added a commit
that referenced
this pull request
Jan 5, 2021
…into black_plugin * 'autorestv3' of https://github.com/Azure/autorest.python: fix default polling method listed in docstring (#830) add enum description son top of declaration, wrap comments (#844) add default value 'api-key' for `--credential-key-header-name` (#840) update head-as-boolean spec
iscai-msft
added a commit
that referenced
this pull request
Jan 7, 2021
…into docs * 'autorestv3' of https://github.com/Azure/autorest.python: add black flag (#836) fix default polling method listed in docstring (#830) add enum description son top of declaration, wrap comments (#844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #841
added tests based off of @jsntcy request, see this merged pr for the test case I added.
As proof sphinx renders it the same whether an enum comment is on the same line or not, here's rendering of before and after this fix
before
after:
cc @00Kai0