Skip to content

Add azure mgmt core to setup #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 7 commits into from
Aug 5, 2020
Merged

Add azure mgmt core to setup #738

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3833b2d
add azure-mgmt-core dependency in setup.py if azure-arm is true
iscai-msft Aug 3, 2020
e901730
regenerate
iscai-msft Aug 3, 2020
260b6ad
update changelog
iscai-msft Aug 3, 2020
637fc63
Merge branch 'autorestv3' into add_azure_mgmt_core_to_setup
iscai-msft Aug 3, 2020
63b1165
Merge branch 'autorestv3' of https://github.com/Azure/autorest.python…
iscai-msft Aug 5, 2020
9c5bc36
add upper limit for azure-mgmt-core dependency
iscai-msft Aug 5, 2020
887d609
Merge branch 'add_azure_mgmt_core_to_setup' of https://github.com/Azu…
iscai-msft Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autorest/codegen/templates/setup.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% set name = code_model.options["package_name"] or code_model.class_name %}
{% set azure_mgmt_core_import = ', "azure-mgmt-core>=1.2.0"' if code_model.options["azure_arm"] else "" %}
Copy link
Member

@lmazuel lmazuel Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"azure-mgmt-core<2.0.0,>=1.2.0"

# coding=utf-8
{{ code_model.options['license_header'] }}
# coding: utf-8
Expand All @@ -15,7 +16,7 @@ VERSION = "{{ code_model.options.get('package_version', '0.0.0') }}"
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"{{ azure_mgmt_core_import }}]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/AzureSpecials/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]
Copy link
Contributor Author

@iscai-msft iscai-msft Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowest version is 1.2.0 since we're using the new http_logging_policy property (changelog here)


setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/CustomUrlPaging/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/Head/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/HeadExceptions/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/HeadWithAzureKeyCredentialPolicy/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/Lro/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/Paging/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/StorageManagementClient/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down
2 changes: 1 addition & 1 deletion test/azure/Expected/AcceptanceTests/SubscriptionIdApiVersion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]

setup(
name=NAME,
Expand Down