Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pylint] override scoring to include info warnings #2813

Closed
wants to merge 31 commits into from

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Sep 3, 2024

fixes #2802

default pylint scoring is: (max(0, 0 if fatal else 10.0 - ((float(5 * error + warning + refactor + convention)/ statement) * 10)))

adding in +info

eng/scripts/run_pylint.py Outdated Show resolved Hide resolved
@iscai-msft
Copy link
Contributor

ooh perfect, thank you so much @l0lawrence, the CI is now failing which is good. Going to take a look at this later today

@l0lawrence
Copy link
Member Author

Hi @msyyc, @tadelesh I think @iscai-msft is OOF, if you get a chance could you please take a look at the pylint warnings here?

They are related to this issue:#2802

@msyyc
Copy link
Member

msyyc commented Sep 27, 2024

Hi @msyyc, @tadelesh I think @iscai-msft is OOF, if you get a chance could you please take a look at the pylint warnings here?

They are related to this issue:#2802

Sure. Now we are migrating some code to https://github.com/microsoft/typespec/tree/main/packages/http-client-python which has strict ETA so we will take a look after the migration done.

@iscai-msft
Copy link
Contributor

The migration issue should also solve the pylint issues, since I fixed the pylint issues in the unbranded emitter. We have updated the branded emitter (the existing one we use to generate azure code) to depend fully on the unbranded emitter, so the code emitted by it should have the pylint issues solved. There is some issue with migrating the tsp-client update to the version with the fixed pylint issues, so we haven't published it in azure-sdk-for-python repo yet, but once that is done, the pylint issues should be fixed. I'm working on that issue today

@msyyc
Copy link
Member

msyyc commented Oct 18, 2024

move to #2876

@msyyc msyyc closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pylint] Useless-disable flagging on generated code
3 participants