Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read error response in try catch #2684

Merged
merged 4 commits into from
Jul 10, 2024
Merged

read error response in try catch #2684

merged 4 commits into from
Jul 10, 2024

Conversation

iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Jul 9, 2024 •
edited
Loading

fixes #2685

iscai-msft and others added 2 commits July 9, 2024 15:39
@msyyc
Copy link
Member

msyyc commented Jul 10, 2024

@iscai-msft overall looks good and I commit a little optimization to your PR.

@msyyc msyyc enabled auto-merge (squash) July 10, 2024 03:48
@msyyc msyyc merged commit 55144a7 into main Jul 10, 2024
15 checks passed
@msyyc msyyc deleted the check_error_read branch July 10, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc msyyc approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore stream consumption errors when reading streams before throwing an error
2 participants
@iscai-msft @msyyc