Fix for construct headers and queries when build request #2681

msyyc · 2024-07-04T09:51:04Z

packages/typespec-python/generator/pygen/codegen/serializers/builder_serializer.py

msyyc · 2024-07-05T05:34:28Z

packages/typespec-python/generator/pygen/codegen/serializers/builder_serializer.py

@@ -410,14 +410,19 @@ def _json_response_template_name(self) -> str:
        return "response.json()"

    @staticmethod
-    def declare_non_inputtable_constants(builder: RequestBuilderType) -> List[str]:
+    def declare_non_inputtable_headers_queries(builder: RequestBuilderType) -> List[str]:


It is used for "construct headers and queries" so we had better update the function name with its usage scenario:

autorest.python/packages/typespec-python/generator/pygen/codegen/serializers/builder_serializer.py

Lines 469 to 498 in 3b89887

def serialize_headers(self, builder: RequestBuilderType) -> List[str]:

headers = [

h

for h in builder.parameters.headers

if not builder.has_form_data_body or h.wire_name.lower() != "content-type"

]

retval = ["# Construct headers"] if headers else []

for header in headers:

retval.extend(

self.parameter_serializer.serialize_query_header(

header,

"headers",

self.serializer_name,

self.code_model.is_legacy,

)

)

return retval

def serialize_query(self, builder: RequestBuilderType) -> List[str]:

retval = ["# Construct parameters"]

for parameter in builder.parameters.query:

retval.extend(

self.parameter_serializer.serialize_query_header(

parameter,

"params",

self.serializer_name,

self.code_model.is_legacy,

)

)

return retval

msyyc · 2024-07-05T05:42:46Z

...vanilla/legacy/Expected/AcceptanceTests/BodyString/bodystring/operations/_enum_operations.py

@@ -117,7 +117,6 @@ def build_put_referenced_constant_request(**kwargs: Any) -> HttpRequest:

    content_type: Optional[str] = kwargs.pop("content_type", _headers.pop("Content-Type", None))
    accept = _headers.pop("Accept", "application/json")
-    color_constant = "green-color"


unused variable

msyyc added 2 commits July 4, 2024 17:47

init

60f74ce

changelog

8d68581

msyyc commented Jul 4, 2024

View reviewed changes

packages/typespec-python/generator/pygen/codegen/serializers/builder_serializer.py Outdated Show resolved Hide resolved

msyyc added 3 commits July 5, 2024 13:25

fix

1d00eb8

fix

536a1cd

fix

6627d1e

msyyc commented Jul 5, 2024

View reviewed changes

msyyc changed the title ~~only construct headers for constant~~ Fix for construct headers and queries when build request Jul 5, 2024

msyyc and others added 2 commits July 5, 2024 13:35

Update HEAD-2024-6-4-17-48-51.md

a20e902

changelog

80da759

msyyc commented Jul 5, 2024

View reviewed changes

msyyc marked this pull request as ready for review July 5, 2024 06:35

msyyc requested review from iscai-msft and tadelesh as code owners July 5, 2024 06:35

iscai-msft merged commit 507d8ca into main Jul 8, 2024
15 checks passed

iscai-msft deleted the fix-bug-header branch July 8, 2024 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for construct headers and queries when build request #2681

Fix for construct headers and queries when build request #2681

msyyc commented Jul 4, 2024

msyyc Jul 5, 2024 •

edited

Loading

msyyc Jul 5, 2024

	def serialize_headers(self, builder: RequestBuilderType) -> List[str]:
	headers = [
	h
	for h in builder.parameters.headers
	if not builder.has_form_data_body or h.wire_name.lower() != "content-type"
	]
	retval = ["# Construct headers"] if headers else []
	for header in headers:
	retval.extend(
	self.parameter_serializer.serialize_query_header(
	header,
	"headers",
	self.serializer_name,
	self.code_model.is_legacy,
	)
	)
	return retval

	def serialize_query(self, builder: RequestBuilderType) -> List[str]:
	retval = ["# Construct parameters"]
	for parameter in builder.parameters.query:
	retval.extend(
	self.parameter_serializer.serialize_query_header(
	parameter,
	"params",
	self.serializer_name,
	self.code_model.is_legacy,
	)
	)
	return retval

Fix for construct headers and queries when build request #2681

Fix for construct headers and queries when build request #2681

Conversation

msyyc commented Jul 4, 2024

msyyc Jul 5, 2024 • edited Loading

Choose a reason for hiding this comment

msyyc Jul 5, 2024

Choose a reason for hiding this comment

msyyc Jul 5, 2024 •

edited

Loading