modify serialization to check for text plan content type #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 20, 2024 15:58
…fix_pipeline_response_deserialization
lmazuel
reviewed
Jun 20, 2024
| @@ -105,7 +105,7 @@ class RawDeserializer: | |||
| # Remove Byte Order Mark if present in string | |||
| data_as_str = data_as_str.lstrip(_BOM) | |||
|
|
|||
| if content_type is None: | |||
| if content_type is None or content_type == "text/plain": | |||
There was a problem hiding this comment.
We solved this problem in azure-core already a while back, I would prefer to stay consistent with azure-core:
https://github.com/Azure/azure-sdk-for-python/blob/999ded5c8cdca182359d40265f08ed10f070c548/sdk/core/azure-core/azure/core/pipeline/policies/_universal.py#L643-L644
There was a problem hiding this comment.
Agree with Laurent that we had better keep consistent with azure-core
…fix_pipeline_response_deserialization
msyyc
reviewed
Jun 21, 2024
| @@ -2498,5 +2498,10 @@ def test_skip_url_encoding(self): | |||
| self.assertEqual("%2Fdatabase%2F%7BObject.value%7D", result2) | |||
|
|
|||
|
|
|||
| def test_deserialize_text(): | |||
| assert "str" == RawDeserializer.deserialize_from_text("str", content_type="text/plain") | |||
| assert "str" == RawDeserializer.deserialize_from_text(b"str", content_type="text/plain") | |||
There was a problem hiding this comment.
Add test case to cover this scenario
|
thanks @msyyc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2647