Fix internal model typing #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
reviewed
Apr 16, 2024
tadelesh
reviewed
Apr 16, 2024
…fix-internal-model-typing
iscai-msft
reviewed
Apr 23, 2024
…fix-internal-model-typing
iscai-msft
reviewed
Apr 24, 2024
| retval = f"{self.code_model.models_filename}.{retval}" | ||
| return retval if is_operation_file else f'"{retval}"' | ||
| skip_quote = kwargs.get("skip_quote", False) | ||
| retval = typing_name( |
There was a problem hiding this comment.
i think it's messier to , because looking at this code, it's a bunch of information that goes into a black box with .
I would be ok with either duplicating this code, or having a helper function that is much simpler, like add_models_file_to_path
There was a problem hiding this comment.
Fine. To make it clear, I remove the helper function
…fix-internal-model-typing
…autorest.python into fix-internal-model-typing
|
Face is waiting for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2507
The PR includes: