Skip to content

bump tooling version and replaying https://github.com/Azure/autorest/pull/2531 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olydis merged 2 commits into from
Aug 30, 2017
Merged

bump tooling version and replaying https://github.com/Azure/autorest/pull/2531 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f2407
bump tool version
Aug 28, 2017
110c0c3
If LRO + Pageable, choose LRO
lmazuel Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/autorest.python.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
<Folder Include="Properties\" />
</ItemGroup>
<ItemGroup>
<DotNetCliToolReference Include="dotnet-Perks.CodeGen" Version="1.0.16" />
<PackageReference Include="dotnet-Perks.CodeGen" Version="1.0.16">
<DotNetCliToolReference Include="dotnet-Perks.CodeGen" Version="2.0.1" />
<PackageReference Include="dotnet-Perks.CodeGen" Version="2.0.1">
<PrivateAssets>All</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down
8 changes: 8 additions & 0 deletions src/azure/TransformerPya.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ private void TransformPagingMethods(CodeModelPya codeModel)
{
var pageableExtension =
method.Extensions[AzureExtensions.PageableExtension] as Newtonsoft.Json.Linq.JContainer;

/* We don't support LRO + Paging at the same time for now */
if (method.Extensions.ContainsKey(AzureExtensions.LongRunningExtension))
{
method.Extensions.Remove(AzureExtensions.PageableExtension);
continue;
}

var operationName = (string) pageableExtension["operationName"];
if (operationName != null)
{
Expand Down