Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Signal method and delegate to provide a hook into events #602

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Emit Signal method and delegate to provide a hook into events #602

merged 2 commits into from
Jun 29, 2020

Conversation

georgend
Copy link
Contributor

Emit Signal method in non Azure Modules, to allow us to hook into event system for cross cutting concerns such as logging HTTP Requests/Responses when -Debug parameter is specified.

Call Init() in the Module private constructor to light up the CustomInit() pattern.

@darrelmiller
Copy link
Member

Hey @dolauli would it be possible to get this reviewed an merged. These additional hooks will allow us to implement a proper -debug feature in our Microsoft Graph PowerShell. Thanks!

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are required.

@georgend georgend requested a review from dolauli June 25, 2020 13:49
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dolauli
Copy link
Contributor

dolauli commented Jun 29, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants