eng, add apply patches as post sdk-sync step #3178
Conversation
weidongxu-microsoft
requested review from
XiaofeiCao,
haolingdong-msft and
srnagar
as code owners
There was a problem hiding this comment.
This file name change is not due to the adding of patches in "sync_sdk" apply_patches
Just my feeling that we'd better to make this file .patch too (instead of .diff).
| @@ -0,0 +1,2009 @@ | |||
| From 0c42d779a7065394e10a48d3985e81702eb754b3 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Curious how are those patch files generated? By agent?
There was a problem hiding this comment.
How other languages handle accepted header changes?
There was a problem hiding this comment.
These patches are generated by my reverts on SDK PR Azure/azure-sdk-for-java#46302
git format-patch -n 1 <sha>
At present, only .NET and Java has this "regen" step.
.NET has recording both on data-plane and mgmt-plane. On data-plane, they would let Redmond to solve. On mgmt-plane, they plan to update TestBase to let test-proxy ignore this header.
There was a problem hiding this comment.
Thanks! curious why do we change the generated sdk, instead of updating the recording to reflect the real sdk serialized headers?
Currently, these patches are to revert the changes to
acceptheaders on request without response body.