Skip to content

Fix required+readonly properties incorrectly included in initialization constructors #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix required+readonly properties incorrectly included in initialization constructors #5424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f31efa
Initial plan
Copilot Nov 6, 2025
de2acf9
Fix required+readonly properties in initialization constructor
Copilot Nov 6, 2025
271b283
Regenerate test projects with fixed constructor logic
Copilot Nov 6, 2025
6131f51
Remove unused test TypeSpec file
Copilot Nov 6, 2025
66575ab
Remove incorrectly generated tsp-output files
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AutoRest.CSharp/Common/Output/Models/Types/SchemaObjectType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ protected override ObjectTypeConstructor BuildInitializationConstructor()
// Turn constants into initializers
initializationValue = BuilderHelpers.ParseConstant(property.InputModelProperty!.ConstantValue.Value, propertyType);
}
else if (IsStruct || property.InputModelProperty?.IsRequired == true)
else if ((IsStruct || property.InputModelProperty?.IsRequired == true) && property.InputModelProperty?.IsReadOnly != true)
{
// For structs all properties become required
Constant? defaultParameterValue = null;
Expand Down
Loading
Loading