Don't use C# name in model dictionary #5376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
customer-reported
m-nash
reviewed
Jul 25, 2025
src/AutoRest.CSharp/Common/Generation/Writers/ModelReaderWriterContextWriter.cs
Show resolved
Hide resolved
sbomer
requested review from
ArthurMa1978,
JoshLove-msft,
hallipr and
lirenhe
as code owners
Contributor
Author
|
@JoshLove-msft looks like this is hitting some issue with the CI, would you be able to help? |
JoshLove-msft
approved these changes
Jul 29, 2025
Member
|
should we expect some MRWContext change in the regen PR Azure/azure-sdk-for-net#51536? |
Member
Never mind, the regen is supposed to be the same, I verified the fix with local regen as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #5375 @m-nash