Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-install for npx command #4927

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Jul 18, 2024

Description

In our regen pipeline, the SDK generations run in parallel, in some situation, there are some conflicts when install tsp-client at the same times via npx which cause the pipeline fail because of invalid tsp-client libraries.
Now, we set option --no-install when call npx to avoid install the tsp-client which may narrow down the probability of confliction.

  • set option --no-install in npx command
  • unpin the tsp-client version

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@chunyu3 chunyu3 marked this pull request as draft July 18, 2024 05:21
@chunyu3 chunyu3 changed the title add --no-install for npx command [Do-not-Merge] add --no-install for npx command Jul 18, 2024
@chunyu3 chunyu3 changed the title [Do-not-Merge] add --no-install for npx command add --no-install for npx command Jul 18, 2024
@chunyu3 chunyu3 marked this pull request as ready for review July 18, 2024 07:26
@chunyu3 chunyu3 added the DPG label Jul 18, 2024
@chunyu3 chunyu3 merged commit 236c4c0 into Azure:feature/v3 Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants