-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove packageReference from project file for management sdk #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
July 17, 2024 09:43
live1206
reviewed
Jul 18, 2024
live1206
reviewed
Jul 18, 2024
live1206
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4913
Problem-tp-solve:
Duplicate compile items
When generate a new service from typespec, the .NET codegen will generate scaffolding (include project file) for this new SDK. In the generated project file it includes several
packageReference
to add compile dependency. But in azure-sdk-for-net, the engsys already include all depended packages for management-plane SDK inDirectory.Build.Common.targets
. So the build will fail because ofduplicate compile items
.Solution:
Since existing SDKs in
azure-sdk-for-net
contain define thosepackageRefernce
in each SDK's project file, and we also need to support management SDKs from swagger which use the dotnet templates to create scaffolding folder, we decide to change in codegen side to removepackageReference
when create scaffolding which will keep consistent with current SDKs.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?