Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the UsageFlags from TCGC directly in our emitter #4917

Merged

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jul 16, 2024

Takes the emitter changes from microsoft/typespec#3842

Description

This PR updates the version of emitter, which takes the usageFlags from TCGC directly to models and enums.
This means now our code model takes whatever the usage calculated by TCGC, we no longer do any patches or appendix to the usage any more.

We have a requirement that we do not generate convenience method for PATCH until it is ready. We still maintain this behavior, but the usage is controlled by TCGC which does not know the convenience method for PATCH should be excluded.
Therefore a diagnostic warning has been added to the emitter so that if the convenience method of PATCH is NOT disabled, a warning will be reported telling you that the operation should add @convenienceAPI(false).

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review July 16, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants