-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the UsageFlags
from TCGC directly in our emitter
#4917
Merged
ArcturusZhang
merged 18 commits into
Azure:feature/v3
from
ArcturusZhang:use-usage-flag-from-tcgc-new
Jul 25, 2024
Merged
Use the UsageFlags
from TCGC directly in our emitter
#4917
ArcturusZhang
merged 18 commits into
Azure:feature/v3
from
ArcturusZhang:use-usage-flag-from-tcgc-new
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
July 16, 2024 08:30
archerzz
reviewed
Jul 22, 2024
test/AutoRest.TestServer.Tests/Common/Utilities/NamedTypeSymbolExtensionsTests.cs
Show resolved
Hide resolved
test/CadlRanchProjects/parameters/body-optionality/src/Generated/BodyOptionalityClient.cs
Show resolved
Hide resolved
archerzz
approved these changes
Jul 24, 2024
chunyu3
reviewed
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the emitter changes from microsoft/typespec#3842
Description
This PR updates the version of emitter, which takes the usageFlags from TCGC directly to models and enums.
This means now our code model takes whatever the usage calculated by TCGC, we no longer do any patches or appendix to the usage any more.
We have a requirement that we do not generate convenience method for PATCH until it is ready. We still maintain this behavior, but the usage is controlled by TCGC which does not know the convenience method for PATCH should be excluded.
Therefore a diagnostic warning has been added to the emitter so that if the convenience method of PATCH is NOT disabled, a warning will be reported telling you that the operation should add
@convenienceAPI(false)
.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?