Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new flag to generate the _serializedAdditionalRawData as an internal property #4836

Merged
merged 24 commits into from
Jul 22, 2024

Conversation

ArcturusZhang
Copy link
Member

Fixes #4835

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review June 20, 2024 05:17
@joseharriaga
Copy link
Member

Hello, @ArcturusZhang. I would like to grab an alpha version of the generator with the changes in this PR and test it in the OpenAI library.

Question: My understanding is that the PR pipeline generates an alpha version that I could use for this purpose. Do you know where can I find it? Also, could I ask you to rebase this PR on top of a more recent version of CodeGen? We're currently on version 3.0.0-beta.20240628.1, so anything after that should work. 😊

@ArcturusZhang
Copy link
Member Author

Hello, @ArcturusZhang. I would like to grab an alpha version of the generator with the changes in this PR and test it in the OpenAI library.

Question: My understanding is that the PR pipeline generates an alpha version that I could use for this purpose. Do you know where can I find it? Also, could I ask you to rebase this PR on top of a more recent version of CodeGen? We're currently on version 3.0.0-beta.20240628.1, so anything after that should work. 😊

Sorry I did not notice the message :(
You could find it here: https://github.com/Azure/azure-sdk-for-net/pull/44667/files#diff-93a28d9569550c68624a8ad2209a6fae1d4f88237e4b5414eed2ecac4ef8c98fR225

Since this PR has not been updated for a while, I need to update it and triggers another regen, and you could find the version number in above PR (updated in place)

@trrwilson
Copy link
Member

Verified to achieve the intended effect for the OpenAI .NET library in this draft PR:
joseharriaga/openai-in-typespec#173

Which consumes PR resources from:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3972319&view=artifacts&pathAsName=false&type=publishedArtifacts

Copy link
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to verify the preview before merging. Since everything is gated behind the new flag there should be no diffs other than the version bump.

@ArcturusZhang ArcturusZhang merged commit ee30f57 into Azure:feature/v3 Jul 22, 2024
8 checks passed
@ArcturusZhang ArcturusZhang deleted the enable-internal-raw-data branch July 22, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a new flag to generate the _serializedAdditionalRawData as an internal property
4 participants