Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of json-serialize-refs #4783

Closed

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented May 30, 2024

Description

Take the main logic from https://github.com/devel0/json-serialize-refs/blob/master/src/lib/stringify-refs.ts to make it under our maintenance to avoid possible supply chain attacks considering it has not been updated for a few years.

Modifications:

  • Change the id to start from 0 so that the json object itself should have an id of 0 and everything we care starting from 1.
  • Remove the currently unnecessary option to reduce complexity.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@@ -0,0 +1,72 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArcturusZhang : I'm not 100% sure this is allowable. Please reach out to our PM team and collaborate with them to engage the MS Open Source office for guidance.

@ArcturusZhang ArcturusZhang marked this pull request as draft June 3, 2024 02:45
Copy link
Contributor

Hi @ArcturusZhang. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Aug 9, 2024
Copy link
Contributor

Hi @ArcturusZhang. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants