-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency of json-serialize-refs
#4783
Conversation
@@ -0,0 +1,72 @@ | |||
// Copyright (c) Microsoft Corporation. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArcturusZhang : I'm not 100% sure this is allowable. Please reach out to our PM team and collaborate with them to engage the MS Open Source office for guidance.
Hi @ArcturusZhang. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @ArcturusZhang. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Description
Take the main logic from https://github.com/devel0/json-serialize-refs/blob/master/src/lib/stringify-refs.ts to make it under our maintenance to avoid possible supply chain attacks considering it has not been updated for a few years.
Modifications:
0
so that the json object itself should have an id of0
and everything we care starting from1
.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?