-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate InputPrimitiveType
, InputDateTimeType
, InputDurationType
, InputEnumType
and InputIntrinsicType
with TCGC
#4707
Merged
ArcturusZhang
merged 8 commits into
Azure:feature/v3
from
ArcturusZhang:fix-float-object-issue
Jun 3, 2024
Merged
Consolidate InputPrimitiveType
, InputDateTimeType
, InputDurationType
, InputEnumType
and InputIntrinsicType
with TCGC
#4707
ArcturusZhang
merged 8 commits into
Azure:feature/v3
from
ArcturusZhang:fix-float-object-issue
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
commented
May 14, 2024
ArcturusZhang
force-pushed
the
fix-float-object-issue
branch
from
May 15, 2024 10:02
a605302
to
0c16111
Compare
This was referenced May 17, 2024
Closed
Closed
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
May 20, 2024 06:56
ArcturusZhang
commented
May 20, 2024
chunyu3
reviewed
May 21, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/InputDateTimeType.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
force-pushed
the
fix-float-object-issue
branch
from
May 29, 2024 07:41
97d26b0
to
e6edb5c
Compare
…and literal types
ArcturusZhang
force-pushed
the
fix-float-object-issue
branch
from
May 29, 2024 07:42
e6edb5c
to
a0d8a70
Compare
lirenhe
reviewed
May 30, 2024
lirenhe
reviewed
May 30, 2024
archerzz
reviewed
May 30, 2024
live1206
reviewed
May 31, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/InputDurationType.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Input/InputTypes/InputDateTimeType.cs
Outdated
Show resolved
Hide resolved
archerzz
reviewed
May 31, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/InputDateTimeType.cs
Outdated
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputTypeConverter.cs
Show resolved
Hide resolved
archerzz
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ArcturusZhang
changed the title
trying to consolidate the input types with the types from tcgc
Consolidate May 31, 2024
InputPrimitiveType
, InputDateTimeType
, InputDurationType
, InputEnumType
and InputIntrinsicType
with TCGC
live1206
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to sync shared core
lirenhe
approved these changes
May 31, 2024
ArcturusZhang
added a commit
to ArcturusZhang/typespec
that referenced
this pull request
Jun 3, 2024
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Jun 3, 2024
…harp#4707 (#3503) Migrate changes from `autorest.csharp`: - Azure/autorest.csharp#4688 - Azure/autorest.csharp#4707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4683
Fixes #4712
Fixes #4713
Fixes #4714
Fixes #4131
Description
This PR introduces the following types:
SdkTypeKinds
from TCGC as our kind for all input types (you should see related changes in the emitter and the generator)DateTimeISO8601
. This part fixes Duplicate information in our input type and serialization system #4131InputIntrinsicType
. Onlyunknown
is meaningful to us and in TCGC it is a built-in type with the kind ofany
. Issue has been open for them to rename this to unknown. This part fixes Intrinsic types are not meaningful exceptunknown
#4712ValueType
(formalEnumValueType
) is now aInputPrimitiveType
instead of just a string.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?