Put all optional client parameters into client options#3910
Merged
pshao25 merged 25 commits intoAzure:feature/v3from Nov 28, 2023
Merged
Put all optional client parameters into client options#3910pshao25 merged 25 commits intoAzure:feature/v3from
pshao25 merged 25 commits intoAzure:feature/v3from
Conversation
pshao25
requested review from
ArthurMa1978,
hallipr,
jsquire,
lirenhe and
m-nash
as code owners
…into constructor3706
…into constructor3706
…into constructor3706
…into constructor3706
archerzz
reviewed
Nov 16, 2023
archerzz
approved these changes
Nov 16, 2023
archerzz
approved these changes
Nov 17, 2023
chunyu3
reviewed
Nov 17, 2023
ArcturusZhang
approved these changes
Nov 28, 2023
chunyu3
approved these changes
Nov 28, 2023
lirenhe
approved these changes
Nov 28, 2023
live1206
pushed a commit
to live1206/autorest.csharp
that referenced
this pull request
Dec 11, 2023
* Put all optional client parameters into client options * update * Regenerate all code (any successful run even without change will have a new commit) * update * update * update * update * update * update * update * update * update * update * update * update --------- Co-authored-by: actions-user <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now constructor will only have required parameters, all the optional parameters except endpoint will go to client options.
Regen: Azure/azure-sdk-for-net#40292