Skip to content

Stop using npmrc to consume internal packages#3809

Merged
m-nash merged 9 commits intofeature/v3from
users/pahallis/no-internal
Oct 11, 2023
Merged

Stop using npmrc to consume internal packages#3809
m-nash merged 9 commits intofeature/v3from
users/pahallis/no-internal

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Oct 9, 2023

To prepare for eng/common changes that will no longer create ephemeral .npmrc files when emitter-package.json contains "-alpha", we need to remove our dependency on the npmrc files in favor of url based alpha package versions.

  • Use new emitter-package-json creation scripts to avoid npmrc usage in azure-sdk-for-net while still directing alpha packages to the internal feed
  • Use proper leg naming in the matrix. The existing names contained invalid characters
  • Include the leg key as a leg variable so we can use it in the resulting commit message
  • Update emitter-package-json files and Package.Data.props in an initial commit to the PR branch, then reuse that branch as the source for the generation legs instead of sourcing from 'main'
  • Make the variable names used for package versions in build.yml and sdk-update.yml more consistent

@hallipr hallipr force-pushed the users/pahallis/no-internal branch 2 times, most recently from f36f80b to 0678e34 Compare October 9, 2023 23:18
@hallipr hallipr force-pushed the users/pahallis/no-internal branch from 0678e34 to 542cb1f Compare October 9, 2023 23:39
@hallipr hallipr marked this pull request as ready for review October 10, 2023 18:04
@hallipr hallipr force-pushed the users/pahallis/no-internal branch from 24dfd9a to 62a835d Compare October 10, 2023 19:58
@m-nash m-nash merged commit e7041b2 into feature/v3 Oct 11, 2023
@m-nash m-nash deleted the users/pahallis/no-internal branch October 11, 2023 17:15
ArcturusZhang added a commit to ArcturusZhang/autorest.csharp that referenced this pull request Oct 12, 2023
ArcturusZhang added a commit to ArcturusZhang/autorest.csharp that referenced this pull request Oct 13, 2023
live1206 pushed a commit to live1206/autorest.csharp that referenced this pull request Dec 11, 2023
* Stop using npmrc to consume internal packages

* Use latest azure-sdk-tools tag

* Use renamed emitter artifact files

* Fix overrides path parameter

* Remove trailing curly brackets from  overrides path

* Add typespec changes

* Comment out test steps

* Uncomment tests in sdk-update.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants