Skip to content

Move ErrorResponse into HttpPipelineExtensions #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annelo-msft merged 6 commits into from
Sep 7, 2023
Merged

Move ErrorResponse into HttpPipelineExtensions #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
495057e
Move ErrorResponse into HttpPipelineExtensions
annelo-msft Sep 6, 2023
27e3c74
Merge remote-tracking branch 'upstream/feature/v3' into unshare-error…
annelo-msft Sep 6, 2023
8af68c9
temp checkout from branch
annelo-msft Sep 6, 2023
9ba8436
fix bug
annelo-msft Sep 6, 2023
f33221d
try again
annelo-msft Sep 6, 2023
ce794a1
undo syncing from special branch and point back to main
annelo-msft Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
<Compile Include="$(AzureCoreSharedSources)ChangeTrackingList.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)DiagnosticScope.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)DiagnosticScopeFactory.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)ErrorResponse.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)FixedDelayWithNoJitterStrategy.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)FormUrlEncodedContent.cs" LinkBase="Shared/Core" />
<Compile Include="$(AzureCoreSharedSources)ForwardsClientCallsAttribute.cs" LinkBase="Shared/Core" />
Expand Down
1 change: 0 additions & 1 deletion eng/DownloadSharedSource.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ $files = @('AsyncLockWithValue.cs', 'ClientDiagnostics.cs', 'DiagnosticScope.cs'
'ForwardsClientCallsAttribute.cs', 'AsyncLockWithValue.cs', 'VoidValue.cs', 'AzureResourceProviderNamespaceAttribute.cs',
'ChangeTrackingDictionary.cs',
'ChangeTrackingList.cs',
'ErrorResponse.cs',
'FormUrlEncodedContent.cs',
'HttpPipelineExtensions.cs',
'IOperationSource.cs',
Expand Down
23 changes: 0 additions & 23 deletions src/assets/Azure.Core.Shared/ErrorResponse.cs
View file
Open in desktop

This file was deleted.

16 changes: 16 additions & 0 deletions src/assets/Azure.Core.Shared/HttpPipelineExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,21 @@ private static (CancellationToken CancellationToken, ErrorOptions ErrorOptions)

return (requestContext.CancellationToken, requestContext.ErrorOptions);
}

internal class ErrorResponse<T> : Response<T>
{
private readonly Response _response;
private readonly RequestFailedException _exception;

public ErrorResponse(Response response, RequestFailedException exception)
{
_response = response;
_exception = exception;
}

public override T Value { get => throw _exception; }

public override Response GetRawResponse() => _response;
}
}
}