Skip to content

Draft of the document on "How to mock extension method in mgmt SDKs"#3646

Closed
ArcturusZhang wants to merge 6 commits intoAzure:feature/v3from
ArcturusZhang:draft-doc-for-extension-method-mocking
Closed

Draft of the document on "How to mock extension method in mgmt SDKs"#3646
ArcturusZhang wants to merge 6 commits intoAzure:feature/v3from
ArcturusZhang:draft-doc-for-extension-method-mocking

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Aug 8, 2023

Related issue: #3493

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang
Copy link
Member Author

ArcturusZhang commented Aug 8, 2023

@m-nash @KrzysztofCwalina @tg-msft could you also have a review on this to see if anything is missing in this doc?

Related implementations: #3483 and Azure/azure-sdk-for-net#37927

@scottaddie
Copy link
Member

@ArcturusZhang Let's hold off on merging this PR. The content is better suited for learn.microsoft.com.

@ArcturusZhang
Copy link
Member Author

@ArcturusZhang Let's hold off on merging this PR. The content is better suited for learn.microsoft.com.

Yes we are not targeting to merge this, just use this PR to collect feedbacks and comments
Also we will release a few beta versions for some libraries and the testers might need a document, this is also for that purpose too

@ArcturusZhang ArcturusZhang added Mgmt This issue is related to a management-plane library. Do Not Merge labels Aug 14, 2023
@ArcturusZhang
Copy link
Member Author

I also added a section for NSubstitute

@microsoft-github-policy-service
Copy link
Contributor

Hi @ArcturusZhang. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@microsoft-github-policy-service
Copy link
Contributor

Hi @ArcturusZhang. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Mgmt This issue is related to a management-plane library. no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants