Align with latest changes in arm core#1301
Closed
ArcturusZhang wants to merge 1 commit intoAzure:feature/v3from
Closed
Align with latest changes in arm core#1301ArcturusZhang wants to merge 1 commit intoAzure:feature/v3from
ArcturusZhang wants to merge 1 commit intoAzure:feature/v3from
Conversation
ArcturusZhang
requested review from
ShivangiReja,
allenjzhang,
chamons,
m-nash and
pakrym
as code owners
ArcturusZhang
force-pushed
the
align-with-latest-armcore
branch
from
74974e7 to
c4ad740
Compare
ArcturusZhang
force-pushed
the
align-with-latest-armcore
branch
from
c4ad740 to
a19e222
Compare
chamons
reviewed
Jun 8, 2021
Contributor
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
Very few code changes, almost all csproj. Here's the tl-dr diff - https://gist.github.com/chamons/c3fc5020b4f8a404c681676953c9be02
Approved from a shared code angle.
Member
|
Closing this in favor of #1302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the code generator with recent changes in Azure.ResourceManager.Core
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?