Skip to content

Update SubResourceWriterable to WriteableSubResource#1249

Merged
m-nash merged 6 commits intoAzure:feature/v3from
AME-Redmond:JonathanCrd-5844-Update-SubResourceWriterable-to-WriteableSubResource
May 18, 2021
Merged

Update SubResourceWriterable to WriteableSubResource#1249
m-nash merged 6 commits intoAzure:feature/v3from
AME-Redmond:JonathanCrd-5844-Update-SubResourceWriterable-to-WriteableSubResource

Conversation

@JonathanCrd
Copy link
Member

Description

Update Azure.ResourceManager.Core version to this PR, and update all references for SubResourceWriterable to WriteableSubResource.

ADO item 5844.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changed in shared code. Seems reasonable enough but fully a mgmt PR to review.

@m-nash m-nash merged commit dca942f into Azure:feature/v3 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments