Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove api server param from helm #285

Merged
merged 4 commits into from
Jun 18, 2019

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Jun 17, 2019

Since AKS is now automatically adding these environment variables to the containers, we don't need to do it anymore. These were added to resolve some connectivity issue between a container and api-server.

KUBERNETES_PORT_443_TCP_ADDR
KUBERNETES_PORT
KUBERNETES_PORT_443_TCP
KUBERNETES_SERVICE_HOST

Before this fix rolled out, we introduced apiServerAddress into the helm chart so that we can set these vars.

Example:

aksClusterConfiguration:
    apiServerAddress: <aks-api-server-address>

Issue outlined on AKS github: Azure/AKS#676

Here is an image with the new deployment yaml showing that env variables are added automatically.
image

@akshaysngupta akshaysngupta merged commit bb0706b into master Jun 18, 2019
@akshaysngupta akshaysngupta deleted the aksgupta/helm/removeapiservervar branch June 18, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants