This repository was archived by the owner on Oct 12, 2023. It is now read-only.
update max user agent length.#42
Merged
Merged
Conversation
ramya-rao-a
reviewed
Apr 15, 2019
| if (userAgent.length > Constants.maxUserAgentLength) { | ||
| throw new Error( | ||
| `The user-agent string cannot be more than 128 characters in length.` + | ||
| `The user-agent string cannot be more than 512 characters in length.` + |
Contributor
There was a problem hiding this comment.
Lets use the constant maxUserAgentLength here instead of hard coding 512.
ramya-rao-a
reviewed
Apr 15, 2019
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Right after creating the connectionOptions object lets use log to log the same.
ramya-rao-a
reviewed
Apr 15, 2019
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Let's also update the version number so we can release the next version today
bterlson
approved these changes
Apr 15, 2019
Member
Author
|
@ramya-rao-a As discussed offline we will add a log for all the connection properties after successfully creating a connection in EventHubs. |
ramya-rao-a
approved these changes
Apr 16, 2019
Contributor
|
@ShivangiReja Azure/azure-sdk-for-js#2270 was the fix done in the main repo to fix the auditing issue. |
Member
|
@ramya-rao-a , @ShivangiReja : PR to update dependencies: #43 |
ramya-rao-a
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes made in the PR. This helps in making better change log
Reference to any github issues