Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --public-fqdn #97

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Add support for --public-fqdn #97

merged 1 commit into from
Jan 17, 2024

Conversation

sblackstone
Copy link
Contributor

Adds support for public-fqdn which is necessary for some private repositories.

Fixes #95

@sblackstone sblackstone requested a review from a team as a code owner April 20, 2023 20:50
@sblackstone
Copy link
Contributor Author

@microsoft-github-policy-service agree

@github-actions
Copy link

github-actions bot commented May 4, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label May 4, 2023
@sblackstone
Copy link
Contributor Author

Any chance this could get a review? It's really straightforward....

@github-actions github-actions bot removed the idle Inactive for 14 days label May 5, 2023
davidgamero
davidgamero previously approved these changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks for the PR!

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label May 20, 2023
@piroinno
Copy link

Can this PR be approved

@github-actions github-actions bot removed the idle Inactive for 14 days label Jul 10, 2023
OliverMKing
OliverMKing previously approved these changes Jul 10, 2023
View reviewed changes
@sblackstone sblackstone dismissed stale reviews from OliverMKing and davidgamero via 12ce28a July 10, 2023 18:40
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jul 24, 2023
@sblackstone
Copy link
Contributor Author

I pushed a fix for the one issue that was mentioned, needs to be re-approved.

@github-actions github-actions bot removed the idle Inactive for 14 days label Jul 25, 2023
@sblackstone
Copy link
Contributor Author

Can this please be merged.

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Aug 15, 2023
@MattHodge
Copy link

@OliverMKing looks like this just needs your stamp of approval

@github-actions github-actions bot removed the idle Inactive for 14 days label Oct 26, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 9, 2023
@sblackstone
Copy link
Contributor Author

Could we please merge this. It's been 6 months - I fixed the single issue that came up in review.

@github-actions github-actions bot removed the idle Inactive for 14 days label Nov 11, 2023
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 25, 2023
@sblackstone
Copy link
Contributor Author

sblackstone commented Jan 9, 2024 •
edited
Loading

Could we please merge this. It's been 9 months - I fixed the single issue that came up in review.

@github-actions github-actions bot removed the idle Inactive for 14 days label Jan 9, 2024
davidgamero
davidgamero approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit 00bee73 into Azure:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamero davidgamero davidgamero approved these changes

@OliverMKing OliverMKing OliverMKing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: enable conditional --public-fqdn parameter
5 participants
@sblackstone @piroinno @MattHodge @davidgamero @OliverMKing