Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: enable conditional --public-fqdn parameter #95

Closed
SylwiaBrant opened this issue Feb 22, 2023 · 4 comments · Fixed by #97
Closed

Feature Request: enable conditional --public-fqdn parameter #95

SylwiaBrant opened this issue Feb 22, 2023 · 4 comments · Fixed by #97
Labels
idle Inactive for 14 days

Comments

@SylwiaBrant
Copy link

Feature request

It would be great, if the command took into account the --public-fqdn parameter, while logging into the cluster. As stated in the Azure CLI documentation:

--public-fqdn
Get private cluster credential with server address to be public fqdn.
default value: False

It could be just a bool in the actions yaml to enable this :)

@OliverMKing
Copy link
Collaborator

This seems like a good feature. We will add it when we get to the time. Alternatively, we would accept PRs that add this.

Thanks for the suggestion!

@kxs-sindrakumar
Copy link

What is the workaround until this feature is implemented?

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Mar 30, 2023
@SylwiaBrant
Copy link
Author

Thank you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants