Feat: support run kubectl on AKS by runcommand - #286
Merged
Merged
Conversation
gossion
force-pushed
the
guwe/run-cmd-header
branch
2 times, most recently
from
January 21, 2026 07:37
f78dfa2 to
cfb9af1
Compare
gossion
commented
Jan 22, 2026
| "Comma-separated list of allowed Kubernetes namespaces (empty means all namespaces)") | ||
|
|
||
| // Multi-cluster configuration | ||
| flag.BoolVar(&cfg.EnableMultiCluster, "enable-multi-cluster", false, |
Member
Author
There was a problem hiding this comment.
is this flag good, or do we have better flag?
Member
Author
There was a problem hiding this comment.
Fei Guo (@Fei-Guo) got a good idea to call it '--token-auth-only', thanks.
gossion
marked this pull request as ready for review
January 22, 2026 05:50
Qingchuan Hao (mainred)
approved these changes
Jan 22, 2026
Member
Author
|
don't merge before HolmesGPT/holmesgpt#1397 is merged. maybe there is some change needed. |
gossion
force-pushed
the
guwe/run-cmd-header
branch
from
January 23, 2026 06:46
d12188e to
73ff6c5
Compare
Fei Guo (Fei-Guo)
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.