use official docker cli windows binary #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northtyphoon
requested review from
juliusl,
sajayantony and
shahzzzam
as code owners
jaysterp
reviewed
Nov 11, 2019
| git checkout $env:DOCKER_CLI_LKG_COMMIT; \ | ||
| scripts\\make.ps1 -Binary -ForceBuildAll | ||
| # Download the docker executable | ||
| FROM base as dockercli |
There was a problem hiding this comment.
@northtyphoon where is this base image stored? #Resolved
There was a problem hiding this comment.
It's a multi-stage dockerfile. base is defined in the first stage
ARG WINDOWS_IMAGE=mcr.microsoft.com/windows/servercore:1903
FROM $WINDOWS_IMAGE as base
In reply to: 344888115 [](ancestors = 344888115)
jaysterp
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
The change switches to official docker cli windows build for window container images.
As golang/go#35447, the change also downgrades golang for windows to 1.13.2
Fixes #542
Fixes #451