[FEAT] Add Scoring to PromptSendingOrchestrator #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Jun 28, 2024
romanlutz
reviewed
Jun 28, 2024
romanlutz
reviewed
Jun 28, 2024
rlundeen2
reviewed
Jun 28, 2024
rlundeen2
reviewed
Jun 28, 2024
nina-msft
commented
Jun 29, 2024
romanlutz
reviewed
Jun 29, 2024
nina-msft
commented
Jul 1, 2024
romanlutz
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds scoring to the PromptSendingOrchestrator to allow users the option to provide scorers to score the prompts they are sending at the same time. Scores are stored in the database with reference to the PromptMemoryEntry by prompt_request_response_id.
Changes variables for Scorer classes to all be
self._score_categoryorself._score_categoriesfor consistency.Tests and Documentation
Two new unit tests added to check functionality of
get_score_memory()function and the addition of scoring to the orchestrator.Jupytext was run for the addition to the existing demo for send all prompts.