-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT Add AzureOpenAIGPTVChatTarget to Support MultiModal #160
Merged
rdheekonda
merged 25 commits into
Azure:main
from
rdheekonda:users/rdheekonda/add-multimodal-support-to-aoai-chat-target
Apr 26, 2024
Merged
FEAT Add AzureOpenAIGPTVChatTarget to Support MultiModal #160
rdheekonda
merged 25 commits into
Azure:main
from
rdheekonda:users/rdheekonda/add-multimodal-support-to-aoai-chat-target
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdheekonda
changed the title
Users/rdheekonda/add multimodal support to aoai chat target
[DRAFT] FEAT Add multimodal support to AzureOpenAIChatTarget
Apr 22, 2024
cseifert1
suggested changes
Apr 22, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
rlundeen2
reviewed
Apr 23, 2024
romanlutz
reviewed
Apr 23, 2024
rdheekonda
changed the title
[DRAFT] FEAT Add multimodal support to AzureOpenAIChatTarget
[DRAFT] FEAT Add AzureOpenAIGPTVChatTarget to support MultiModal
Apr 25, 2024
rlundeen2
reviewed
Apr 25, 2024
rdheekonda
changed the title
[DRAFT] FEAT Add AzureOpenAIGPTVChatTarget to Support MultiModal
FEAT Add AzureOpenAIGPTVChatTarget to Support MultiModal
Apr 25, 2024
cseifert1
approved these changes
Apr 25, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
Apr 26, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
reviewed
Apr 26, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
Apr 26, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
Apr 26, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
Apr 26, 2024
rlundeen2
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing in my review I feel most strongly about is the testing comments, but everything is looking great. I'd love to see most of these changes but no blockers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new AzureOpenAIGPTVChatTarget class supports multimodal input (text and image) and generates textual output.
Created a demo notebook to demonstrate how to run AzureOpenAIGPTVChatTarget.
Implemented functionality to retrieve headers from the environment file and could pass them to the AzureOpenAI clients.
Added a new class
ChatMessageListContent
for GPTV target and testsAdded an end to end multimodal demo using AzureOpenAIGPTVChatTarget and PromptSendingOrchestrator in 3_send_all_prompts notebook
Fixed two bugs: validate function in normalizer_request.py module and set same conversation ID across all prompt request pieces in PromptRequestResponse object
Moving the chat message to its own module.
Adjusted the validation method in PromptRequestResponse to handle chat conversation alternates, fixing existing test cases.
Tests and Documentation