Fix Subscription Api error

[msalemcode]

Description

This PR addresses a critical issue in the deployment script (Deploy.ps1) where an API call is made to check if a KeyVault (KV) exists before the subscriptionID is properly assigned. This premature API call results in an error due to the lack of a valid subscriptionID. The error message encountered is as follows:
ERROR: Bad Request({"error":{"code":"InvalidSubscriptionId","message":"The provided subscription identifier 'providers' is malformed or invalid."}})

Changes Made

• Modified the Deploy.ps1 script to ensure that the subscriptionID is assigned before any API calls are made. This change prevents the aforementioned error by ensuring that a valid subscriptionID is available for the API call that checks for the existence of a KeyVault.

Impact

• This change fixes the deployment failure issue by correcting the order of operations in the script. By setting the subscriptionID before making the API call, we avoid the InvalidSubscriptionId error and ensure a smoother deployment process.

Testing

• The updated script has been tested to confirm that the subscriptionID is correctly assigned before the API call is made. This ensures that the deployment process proceeds without encountering the InvalidSubscriptionId error.

Conclusion

This PR resolves a critical bug in the deployment process by adjusting the sequence of operations in the Deploy.ps1 script, thereby ensuring a successful deployment without errors related to the subscriptionID.

[007zszmz]

looks nice.

[neelavarshad]

Tested and validated for required experience. Approved.