Fixes az ADApplicationSecret hyphen parsing error #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where an ADApplicationSecret contains a starting hyphen is not parsed correctly.
santhoshb-msft
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
tested by setting the -- and looks like the current command fails but we have not seen that happen why kv reset as it typically doesnt generate a secret value starting with --. But still a good one just in case, Thank you for your contribution, @tpberntsen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where an ADApplicationSecret containing a starting hyphen is not parsed correctly, resulting in an "argument --value: expected one argument" error when executing the Deploy.ps1 script.