Skip to content

Cisco Firepower v1.0 - #3957

Closed
Clive Watson (clivewatson) wants to merge 5 commits into
Azure:masterfrom
clivewatson:CiscoFirepower
Closed

Cisco Firepower v1.0#3957
Clive Watson (clivewatson) wants to merge 5 commits into
Azure:masterfrom
clivewatson:CiscoFirepower

Conversation

@clivewatson

Copy link
Copy Markdown
Contributor

Initial version


Change(s):

  • New workbook for Cisco Firepower

Reason for Change(s):

  • no vendor supplied workbook

Testing Completed:

  • Yes

Initial version
@ritika-msft

Copy link
Copy Markdown
Contributor

Hi Clive Watson (@clivewatson) , do we still need to merge this PR? As I already see a merged PR from Samik Roy (@samikroy) for Cisco Firepower.

#4089
Please let me know if this PR is still required?

1 similar comment
@ritika-msft

Copy link
Copy Markdown
Contributor

Hi Clive Watson (@clivewatson) , do we still need to merge this PR? As I already see a merged PR from Samik Roy (@samikroy) for Cisco Firepower.

#4089
Please let me know if this PR is still required?

@samikroy

Copy link
Copy Markdown
Contributor

Hi Clive Watson (@clivewatson) , do we still need to merge this PR? As I already see a merged PR from Samik Roy (@samikroy) for Cisco Firepower.

#4089 Please let me know if this PR is still required?

Clive Watson (@clivewatson) - Have created the above mentioned PR with the build errors resolved.
Please have a look and share for any additions needed which can be a new version of this workbook.

@CliveWatsonQC

Copy link
Copy Markdown

ritika-msft - No longer required, you are correct the Samik Roy (@samikroy) for Cisco Firepower one has replaced this.

@ritika-msft

Copy link
Copy Markdown
Contributor

Clive Watson (@clivewatson) thanks for confirming. In that case I will be closing this PR and the issue raised for the same. #4002.

@CliveWatsonQC

Copy link
Copy Markdown

Thank you, Any help or ideas with #4139 would be appreciated?

@ritika-msft

Copy link
Copy Markdown
Contributor

Clive Watson (@clivewatson) sure I will ask my teammates to prioritize the above mentioned PR and get back to you.

@ritika-msft

Copy link
Copy Markdown
Contributor

Closing the PR because it is no more required as per discussion.

@ritika-msft ritika-msft closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants