-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with the Get-DanglingDnsRecords script when DNS contains wild character *.abc.xyz.mno.net against multiple azure subscriptions #365
Comments
Message that will be displayed on users' first issue |
Hello Team, We are also facing the same problem. Can you please up us on it Thanks |
Hello Experts, Greetings for the day Could you please help us on it Thanks |
@abhijeetgaiha / @tanviohri - Please take a look into this issue. |
Hello @abhijeetgaiha , @tanviohri Thank you for helping us it. Could you pls help us with the status if there are any ? |
Hey @Sagarthore11, we'll consider the suggested change after we've tested it out, since this adds handling for DNS entry types the script does not support currently. |
Hello @chinmay0402 Thank you so much for your response. |
@Sagarthore11 @tanviohri @abhijeetgaiha Could you please review this PR submitted for this issue |
Describe the bug
In clear words, please provide a concise description of the bug
We are using Microsoft recommended PowerShell module for identifying dangling DNS in Azure platform and it was working fine for last one year but from last month it's failing with below error message
Powershell module link reference : https://learn.microsoft.com/en-us/azure/security/fundamentals/subdomain-takeover#identify-dangling-dns-entries
Upon investigation found a bug with the module which was unable to handle the DNS entry point name if it has wild character for example *.abc.xyz.mno.net as an entry
It was due to using -match instead of -contains, below is code snippet found an issue
I can fix this either changing from -match to -contains or asking users to delete wild character in DNS name but we have around 100s of DNSs so wouldn't able to control user on creating DNS name so it will be ideal to handle such scenario in the script
Reproduce
Steps to reproduce the behavior:
Install-Module -Name AzDanglingDomain -Scope CurrentUser
Import-Module -Name AzDanglingDomain -Force
Get-DanglingDnsRecords -FetchDnsRecordsFromAzureSubscription
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots/images to help explain your problem.
Environment- if applicable
Desktop (please complete the following information if applicable):
Logs- if applicable
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Invalid pattern '.abc.xyz.mno.net' at offset 1. Quantifier '' following nothing
Additional context
Add any other context about the problem here.
Opened a case with MS for the same and they have directed to open a GitHub issue so that internal team can review.
The text was updated successfully, but these errors were encountered: