Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests #635

Merged
merged 3 commits into from
May 22, 2022
Merged

Adding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests #635

merged 3 commits into from
May 22, 2022

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented May 21, 2022 •
edited
Loading

Overview/Summary

Adds discovery support for resource type: roleEligibilityScheduleRequests.
Closes #476

This PR fixes/adds/changes/removes

  1. Adds new setting called SkipPim with default set to $true. Ensures that any discovery of Privileged Identity Management resources requires opt-in; change setting to $false.
  2. Adds functional test for pull and push of roleEligibilityScheduleRequests.
  3. Changes wiki settings docs.

Breaking Changes

N/A

Testing Evidence

Testing has been performed; final evidence is presented during automated functional testing included in PR.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label May 21, 2022
@Jefajers Jefajers added this to the Release - v1.8.0 milestone May 21, 2022
@Jefajers Jefajers requested review from a team as code owners May 21, 2022 14:20
@Jefajers Jefajers temporarily deployed to test May 21, 2022 14:20 Inactive
@Jefajers Jefajers changed the title Add discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests Adding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests May 21, 2022
@daltondhcp daltondhcp temporarily deployed to test May 22, 2022 13:11 Inactive
@Jefajers Jefajers mentioned this pull request May 22, 2022
Merged
@Jefajers Jefajers temporarily deployed to test May 22, 2022 16:20 Inactive
daltondhcp
daltondhcp approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢

@Jefajers Jefajers merged commit 61755e9 into Azure:main May 22, 2022
@Jefajers Jefajers deleted the Microsoft.Authorization/roleEligibilityScheduleRequests branch May 24, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release - v1.8.0
Development

Successfully merging this pull request may close these issues.

Add discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests
2 participants
@Jefajers @daltondhcp